This repository has been archived by the owner on Oct 28, 2024. It is now read-only.
fix: use random account id in notification endpoint #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes sk22#803. This was due to registering with the actual accounId, whilst saving a random one. Once receiving a notification, the id could not be found.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #803 and LucasGGamerM#254. This was due to registering with the actual account ID while saving a random one. After receiving a notification, the ID could not be found compared to the saved random one, so no notification was displayed.
The problem only occurred when a user tried to re-register with FCM, either by switching from Unified Push or by changing the notification settings, so only some users were affected.