Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR1-813: Handle truncated reads, socket timeouts and reset connections (aka glitches) in S3ChunkStore #363

Merged
merged 26 commits into from
May 4, 2023
Merged

SPR1-813: Handle truncated reads, socket timeouts and reset connections (aka glitches) in S3ChunkStore #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
90693e0
SPR1-813 Retry socket timeouts
ludwigschwardt Feb 22, 2023
d5d86b7
SPR1-813 Improve test comments
ludwigschwardt Feb 22, 2023
124413f
SPR1-813 Parameterise tests involving NPY reads
ludwigschwardt Feb 22, 2023
c8abcb8
SPR1-813 Add "reset-connection" suggestion
ludwigschwardt Feb 23, 2023
f2272da
SPR1-813 Improve checks and error messages
ludwigschwardt Feb 23, 2023
7fcc778
SPR1-813 Collect reset code in a method
ludwigschwardt Feb 23, 2023
5c944b9
SPR1-813 Reset connection while reading data
ludwigschwardt Feb 27, 2023
33d8570
SPR1-813 Test the case of a truncated RDB file
ludwigschwardt Mar 1, 2023
6506cb2
SPR1-813 Early resets are connection errors
ludwigschwardt Mar 1, 2023
b13a6bb
SPR1-813 Different (and shorter) status retries
ludwigschwardt Mar 2, 2023
349a668
SPR1-813 Construct timeouts and retries better
ludwigschwardt Mar 2, 2023
c8cb402
SPR1-813 Restore _raise_for_status
ludwigschwardt Mar 2, 2023
60907a5
SPR1-813 Return response by default, not None
ludwigschwardt Mar 2, 2023
1c9434b
SPR1-813 Do all HTTP request retries ourselves
ludwigschwardt Mar 3, 2023
fdab05d
SPR1-813 Override retries in complete_request too
ludwigschwardt Mar 3, 2023
1f5f3d9
SPR1-813 Don't do all retries ourselves
ludwigschwardt Mar 6, 2023
4b0ed12
SPR1-813 Early resets are read retries
ludwigschwardt Mar 6, 2023
7f6210d
SPR1-813 Rename complete_request -> request
ludwigschwardt Mar 6, 2023
3748349
SPR1-813 Promote retries to a public parameter
ludwigschwardt Mar 6, 2023
5243f89
SPR1-813 Rework _DetectTruncation class
ludwigschwardt Mar 9, 2023
042ca37
SPR1-813 Refactor to improve multi-lines
ludwigschwardt Mar 9, 2023
987315b
SPR1-813 Check lower-level retryable errors
ludwigschwardt Mar 9, 2023
01bf8e2
SPR1-813 Finally fix glitches on RDB file reads
ludwigschwardt Mar 9, 2023
12ecc2c
SPR1-813 Let RDB files retry on reset connections
ludwigschwardt Mar 9, 2023
8db3440
SPR1-813 Explicitly set NPY version 2 in tests
ludwigschwardt Mar 9, 2023
11a824c
SPR1-813 Remove platform-dependent check
ludwigschwardt Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading