[94] Resumable tasks #95
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| _tasks.map.with_index do |task, index| | ||
| task if _tasks[0..index].none? { |_task| task.eql?(_task) } | ||
| tasks = init_tasks | ||
| tasks.map.with_index do |task, index| |
There was a problem hiding this comment.
[reek] reported by reviewdog 🐶
FeatureEnvy: DeployPin::Collector#executable refers to 'tasks' more than self (maybe move it to another class?) [https://github.com/troessner/reek/blob/v6.3.0/docs/Feature-Envy.md]
| task if _tasks[0..index].none? { |_task| task.eql?(_task) } | ||
| tasks = init_tasks | ||
| tasks.map.with_index do |task, index| | ||
| task if tasks[0..index].none? { |other_task| task.eql?(other_task) } |
There was a problem hiding this comment.
[reek] reported by reviewdog 🐶
NestedIterators: DeployPin::Collector#executable contains iterators nested 2 deep [https://github.com/troessner/reek/blob/v6.3.0/docs/Nested-Iterators.md]
| record.update(completed_at: Time.current) | ||
| end | ||
|
|
||
| def increment_progress!(incrementor) |
There was a problem hiding this comment.
[reek] reported by reviewdog 🐶
MissingSafeMethod: DeployPin::Task has missing safe method 'increment_progress!' [https://github.com/troessner/reek/blob/v6.3.0/docs/Missing-Safe-Method.md]
| end | ||
|
|
||
| def prepare | ||
| return if recurring |
There was a problem hiding this comment.
[reek] reported by reviewdog 🐶
RepeatedConditional: DeployPin::Task tests 'recurring' at least 4 times [https://github.com/troessner/reek/blob/v6.3.0/docs/Repeated-Conditional.md]
skcc321
force-pushed
the
ResumableTasks#94
branch
5 times, most recently
from
ca66071
to
b9d6e33
Compare
skcc321
force-pushed
the
ResumableTasks#94
branch
from
b9d6e33
to
7f57ac8
Compare
The purpose of the PR