Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm Modal should submit on Enter key pressed #1758

Closed
wants to merge 2 commits into from
Closed

Confirm Modal should submit on Enter key pressed #1758

wants to merge 2 commits into from

Conversation

ibilux
Copy link
Contributor

@ibilux ibilux commented Jul 17, 2023

Linked Issue

Closes #1757

Description

Confirm Modal should submit true value on Enter key pressed (like closing on Escape key pressed).

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: 4cdc473

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Jul 17, 2023 8:41pm

@endigo9740
Copy link
Contributor

Progress on this is paused while we review the issue I raised here: #1757 (comment)

@endigo9740 endigo9740 marked this pull request as draft July 19, 2023 16:33
@endigo9740
Copy link
Contributor

endigo9740 commented Aug 4, 2023

Per my comment here, we're good to keep the issue, but we'll tackle in another manner in the future:

@endigo9740 endigo9740 closed this Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm Modal should submit on Enter key pressed
2 participants