Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cookies #44

Merged
merged 1 commit into from
Oct 15, 2016
Merged

Support Cookies #44

merged 1 commit into from
Oct 15, 2016

Conversation

brandonbloom
Copy link
Contributor

Fixes #40.

See this corresponding change in express-graphql: graphql/express-graphql#30

Fixes skevy#40.

See this corresponding change in express-graphql: graphql/express-graphql#30
@brandonbloom
Copy link
Contributor Author

A word of warning: I haven't actually tested this change locally. I made it directly on GitHub, sorry about that.

@skevy skevy merged commit 9c5f7ae into skevy:master Oct 15, 2016
@skevy
Copy link
Owner

skevy commented Oct 15, 2016

Thanks!!

@kevinold
Copy link
Collaborator

@brandonbloom Yeah, I'm needing this support too, but when I develop locally, it's not sending a 'Cookies' header to my GraphQL endpoint. See electron/electron#1606 for a bug with electron not supporting Cookies header. I've tried bundling https://www.npmjs.com/package/electron-cookies but doesn't seem to work.

Ideas?

@kevinold
Copy link
Collaborator

I have found away around this by setting cookies in the mainWindow -- see kevinold@9cd8d6d

I'll iterate and open a PR when I like the implementation.

Right now you must set "Cookie" key then "URL!!!NAME!!!VAL" and it's a bit wonky.

Any suggestions are welcome.

@twolfson
Copy link

For anyone curious, another alternative is to open your development site via window.open('my-site') in dev tools and perform any necessary logins there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants