Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the app a little bit of styling #58

Merged
merged 2 commits into from
Apr 10, 2017

Conversation

tarebyte
Copy link
Contributor

@tarebyte tarebyte commented Apr 6, 2017

Just thought I'd give the app a little bit of polish

Before After
screen shot 2017-04-05 at 22 48 47 screen shot 2017-04-05 at 22 48 08
Before After
screen shot 2017-04-05 at 22 49 50 screen shot 2017-04-05 at 22 50 02

Let me know what you all think!

/cc @gjtorikian

@gjtorikian
Copy link
Collaborator

I like it a lot! Are you happy with it? If so I can merge and release a newer version.

I am not sure sure about the Yarnfile to be honest. I like it, in theory. But will there need to be an update to the README or something to tell people to first brew install yarn? If people can get this project and use npm and yarn to manage dependencies side by side, that's cool.

@tarebyte
Copy link
Contributor Author

tarebyte commented Apr 6, 2017

I like it a lot!

💖

Are you happy with it?

I'm pretty happy with how it turned out. If I find more time I might do another iteration but this is good enough ™️ in the meantime.

I am not sure sure about the Yarnfile to be honest. I like it, in theory. But will there need to be an update to the README or something to tell people to first brew install yarn?

I personally use yarn just because I like it better. You can use yarn or npm interchangeably for this app without any issues. But if you'd like me to remove the yarn.lock I'm totally fine with that.

@gjtorikian gjtorikian merged commit 2eabebd into skevy:master Apr 10, 2017
@tarebyte tarebyte deleted the tarebyte/styling branch April 10, 2017 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants