Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Origin header for CORS support #66

Merged
merged 1 commit into from
Jun 17, 2017

Conversation

intellix
Copy link
Contributor

@intellix intellix commented Jun 17, 2017

It seems adding the header inside App.js doesn't work for Origin or User-Agent but you can hack it like this.

I went with: electron://graphiql-app as there's a similar notation for chrome-webapps like: chrome-extension://abc123

Closes #53

@skevy
Copy link
Owner

skevy commented Jun 17, 2017

Thanks!

@skevy skevy merged commit 065766c into skevy:master Jun 17, 2017
@intellix intellix deleted the cors-origin-support branch June 17, 2017 22:21
@Malax Malax mentioned this pull request Aug 8, 2017
madzhup added a commit to madzhup/graphiql-app that referenced this pull request Oct 16, 2017
* source:
  Ok npm wants me to commit this
  Revert "add package lock file (skevy#86)"
  take shell straight of electron and updated button/links (skevy#87)
  add package lock file (skevy#86)
  Update readme (skevy#85)
  add the close query menu item for non-macOS (skevy#71)
  Add Origin header for CORS support (skevy#66)
  Update productName
  Add release command
  Update .gitignore
  Package with Electron Builder, add windows + linux packages
  Fix bad JSON stringify in get requests (skevy#60)
  Update to Babel 6 + GraphiQL 0.10.2/GraphQL 0.10.1

# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants