Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing 'create' trigger for 'push' in Step 0 #86

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

RelicCornhusk
Copy link
Contributor

@RelicCornhusk RelicCornhusk commented Apr 12, 2024

The 'create' trigger does not get picked up once you create a repository from a template. Instead, the 'push' trigger should be used here for this purpose.

Summary

When following the steps in the template repository README and creating a new repository from the template, the GitHub Actions Workflow for 'Step 0: Welcome' does not get triggered. This is because the trigger 'create' being used does not trigger the workflow on this type of event. The only exception to this is if the user creates the repository from the template with the checkbox 'Include all branches' selected. This counts as a branch creation and thus triggers the workflow, however this is not the default option and should not be expected of users.

Changes

Using the push trigger. As per documentation, the pushtrigger runs your workflow when you push a commit or tag, or when you create a repository from a template.

Closes:
#87

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

The 'create' trigger does not get picked up once you create a repository from a template. Instead, the 'push' trigger should be used here for this purpose.
Copy link
Contributor

@sinsukehlab sinsukehlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From skills/template-template

on:
  workflow_dispatch:
  push:
    branches:
      - main

@chadfawcett chadfawcett requested a review from a team April 29, 2024 18:50
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches introduction to GitHub

@heiskr heiskr closed this Apr 30, 2024
@heiskr heiskr reopened this Apr 30, 2024
Copy link
Contributor

@heiskr heiskr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buttons 😂

@heiskr heiskr merged commit 9ac889a into skills:main Apr 30, 2024
@Nomankhan1144
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants