fix: Fix non-functional vim plugin #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vim plugin uses --expect and expects the key used to accept the selection on the first line of output. Commit bcee1f4 "feat!: do not check for expect before printing the argument of accept… (skim-rs#625)" broke that by not outputting anything if the selection was made using the default "enter" key. We can workaround that by explicitly adding "enter" to the --expect argument, so that it once again shows up in the output. Fixes skim-rs/skim.vim#25
dotdash
changed the title
dotdash
force-pushed
the
fix_vim_plugin
branch
from
4283fdd to
5ecf7ae
Compare
LoricAndre
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
check the box if it is not applicable to your changes
Description of the changes
The vim plugin uses --expect and expects the key used to accept the selection on the first line of output. Commit bcee1f4 "feat!: do not check for expect before printing the argument of accept… (#625)" broke that by not outputting anything if the selection was made using the default "enter" key. We can workaround that by explicitly adding "enter" to the --expect argument, so that it once again shows up in the output.
Fixes skim-rs/skim.vim#25