check: fee distribution on failed tx #149
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
commented
Oct 19, 2024
x/feemarket/ante/suite/suite.go
Outdated
| if tc.RunPost && anteErr == nil { | ||
| newCtx, postErr = s.PostHandler(s.Ctx, tx, tc.Simulate, true) | ||
| if tc.RunPost { | ||
| newCtx, postErr = s.PostHandler(s.Ctx, tx, tc.Simulate, anteErr == nil) |
There was a problem hiding this comment.
we should always run the post handler in these tests even if there is an ante handler error. https://docs.cosmos.network/v0.50/learn/advanced/baseapp#runmsgs
aljo242
commented
Oct 19, 2024
| @@ -169,7 +169,7 @@ func TestAnteHandleMock(t *testing.T) { | |||
| } | |||
| }, | |||
| RunAnte: true, | |||
| RunPost: true, | |||
There was a problem hiding this comment.
these were ante handler tests that should not be running a post handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to check if failed tx's result in stuck escrow when
DistributeFeesis true