feat: Constrain the Max to Target block size ratio #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
davidterpay
changed the title
aljo242
reviewed
Dec 5, 2023
aljo242
reviewed
Dec 5, 2023
x/feemarket/types/state_test.go
Outdated
| for { | ||
| state.Update(params.MaxBlockUtilization, params) | ||
| state.UpdateLearningRate(params) | ||
| baseFee := state.UpdateBaseFee(params) |
There was a problem hiding this comment.
I think you can use something like require.Recover() to check that a recover happens
There was a problem hiding this comment.
lemme see if the API supports that, it won't directly panic since it recovers in the same function but we might be able to see if a recover happened
aljo242
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much of the overflow issues that can arise in the fee market occur from the ratio of max / target block sizes. At a high level, this value is utilized to determine how much we should increase/decrease the base fee when there is a discrepancy between the two. When this value is too large, it can cause unintended side consequences including overflow issues.
Additionally, I added panic handlers that should default the fee market to the minimum's in the case when the fee market does come across a overflow error. We may want to visit that logic at a later time.