Skip to content

Commit

Permalink
Revert FIX: Persistence tests failing when using sklearn nightly (#265)
Browse files Browse the repository at this point in the history
Revert "FIX: Persistence tests failing when using sklearn nightly (#260)"

This reverts commit 1b3c674.
  • Loading branch information
adrinjalali authored Jan 16, 2023
1 parent 637b866 commit 7c10331
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions skops/io/tests/_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,13 +126,6 @@ def _assert_vals_equal(val1, val2):


def assert_params_equal(params1, params2):
# due to https://github.com/scikit-learn/scikit-learn/pull/22094, after
# loading an sklearn estimator, there might be an entry called
# "__sklearn_pickle_version__" in the __dict__ that wasn't there before. We
# just ignore it.
params1.pop("__sklearn_pickle_version__", None)
params2.pop("__sklearn_pickle_version__", None)

# helper function to compare estimator dictionaries of parameters
assert len(params1) == len(params2)
assert set(params1.keys()) == set(params2.keys())
Expand Down

0 comments on commit 7c10331

Please sign in to comment.