Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Rename skops.io.save to skops.io.dump #199

Merged
merged 1 commit into from
Oct 21, 2022
Merged

MNT Rename skops.io.save to skops.io.dump #199

merged 1 commit into from
Oct 21, 2022

Conversation

BenjaminBossan
Copy link
Collaborator

As discussed in #182.

Also added a small snippet to docs about using dumps and loads.

@BenjaminBossan
Copy link
Collaborator Author

@skops-dev/maintainers Ready for review.

I grep'ed through the repo, so hopefully I didn't miss any uses of save. However, there are probably examples outside this repo that use save, maybe @merveenoyan could confirm? Those would break right now. We could leave a vestige save = dump but I'd rather only have one way before the release. WDYT?

(re codecov, maybe I'm using it wrong but I just don't see where the -0.01% come from)

adrinjalali
adrinjalali approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@adrinjalali adrinjalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov trigger is because we're removing a previously covered line here, therefore the coverage percentage goes down, I think

LGTM.

@adrinjalali adrinjalali changed the title Rename skops.io.save to skops.io.dump MNT Rename skops.io.save to skops.io.dump Oct 21, 2022
@adrinjalali adrinjalali merged commit e4f820a into skops-dev:main Oct 21, 2022
@BenjaminBossan BenjaminBossan deleted the rename-save-to-dump branch October 21, 2022 13:39
@BenjaminBossan
Copy link
Collaborator Author

The codecov trigger is because we're removing a previously covered line here, therefore the coverage percentage goes down, I think

Ah okay, now I get it, still debatable if this should count as a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrinjalali adrinjalali adrinjalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjaminBossan @adrinjalali