MNT add helper functions to convert types to strings in .audit #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBossan
requested changes
Nov 28, 2022
…f github.com:E-Aho/skops into ENH-Add-helper-functions-to-convert-types-to-strings
adrinjalali
approved these changes
Dec 1, 2022
BenjaminBossan
approved these changes
Dec 1, 2022
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
|
you might want to enable pre-commit hooks, which include |
|
I've got that all set up on my personal computer, trying to wrestle through it on my work laptop atm to get this merged lol |
|
This is a good reminder to me how nice it is to have pre-commit hooks 🙃 Should be good to go now |
adrinjalali
changed the title
|
Note: I change the commit title to MNT since this doesn't expose any changes to the user. I feel like ENH has user-facing implications. |
E-Aho
deleted the
ENH-Add-helper-functions-to-convert-types-to-strings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor changes to the new audit functionality that allows us to pass in types as well as strings as defaults.
This PR adds in a few helper functions to convert from types to their namespace strings, and a helper function that can convert any non-string
defaultsin a passed in list to their namespace.Also includes new tests that cover this added functionality