Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: bug when visualizing byte nodes #352

Merged

Commits on Apr 24, 2023

  1. Fix bug when visualizing byte nodes

    The visualize function failed when trying to visualize models that had
    byte attributes. This is because the node's children would contain raw
    bytes, which the function doesn't know how to visualize. Therefore,
    children of byte and byte array nodes are now skipped (in addition to
    the node types already being skipped).
    
    To test this bug, I added a visualization test to the external packages
    like LightGBM, which make use of bytes. I'm not sure if some of the
    sklearn estimators could also be candidates, but it would surely be
    overkill to test visualizing all of them, whereas the overhead is not so
    big for the external packages.
    BenjaminBossan committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    289a4e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3371ed7 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Show preview of bytes in visualize

    Truncate the number of bytes shown at 24.
    BenjaminBossan committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    ee49944 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ab7445 View commit details
    Browse the repository at this point in the history
  3. Simplify code

    Calling getvalue does not require a seek(0) afterwards.
    BenjaminBossan committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    af522ef View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. Configuration menu
    Copy the full SHA
    9307c77 View commit details
    Browse the repository at this point in the history
  2. Other method to suppress printing to stdout

    More of the visualize stack is running this way, improving test
    coverage.
    BenjaminBossan committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    5cb3038 View commit details
    Browse the repository at this point in the history