Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade bundle require #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryohiy
Copy link

@ryohiy ryohiy commented Oct 6, 2024

This PR upgrades the following packages to address an issue in my environment when trying to use the config options of this package:

  • bundle-require: ^3.0.4 -> ^4.0.4
  • esbuild: ^0.14.21 -> ^0.17.0

Why

When using the config options in my environment, I encountered the following error:

Error: Build failed with 1 error:
/projectA/node_modules/esbuild/lib/main.js:256:12: ERROR: Invalid option in build() call: "watch"

This error appears to be caused by the removal of the watch option in esbuild starting from version 0.17.0. It seems that this PR in the bundle-require repository has addressed this issue while maintaining backward compatibility.

I have confirmed that installing bundle-require version 4.0.0 or higher resolves the error in my environment.

Therefore, I kindly request the upgrade to at least these versions of the packages, so that this error can be avoided.

Thank you for your consideration, and I would appreciate it if you could review this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant