Fix TypeError when generating diff for an object with circular struct…

…ure; fixes mochajs#1179
skozin · Apr 24, 2014 · 4395ae5 · 4395ae5
1 parent ca35545
commit 4395ae5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/reporters/base.js b/lib/reporters/base.js
@@ -466,7 +466,7 @@ function stringify(obj) {
  function canonicalize(obj, stack) {
    stack = stack || [];
 
-   if (utils.indexOf(stack, obj) !== -1) return obj;
+   if (utils.indexOf(stack, obj) !== -1) return '[Circular]';
 
    var canonicalizedObj;
 

diff --git a/mocha.js b/mocha.js
@@ -2317,7 +2317,7 @@ function stringify(obj) {
  function canonicalize(obj, stack) {
    stack = stack || [];
 
-   if (utils.indexOf(stack, obj) !== -1) return obj;
+   if (utils.indexOf(stack, obj) !== -1) return '[Circular]';
 
    var canonicalizedObj;