New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when searching for lyrics of an instrumental track #17

Closed

skuill opened this issue Dec 16, 2023 · 3 comments

Labels

bug

Owner

skuill commented Dec 16, 2023

Artist: HIM, Song: Lucifer's Chorale

skuill added the bug label

Owner Author

skuill commented Dec 16, 2023 •

edited

Loading

Genius provider throw this error while trying to parse the html page with a lyric.
SearchLyric method should not throw any exceptions and break users code. Only log errors.
TODO:

Try Catch providers exceptions and log them.
Properly parse instrumental lyrics in providers.
Mark empty lyric response in case of instrumental lyric.
Add ability to configure logger in client/providers from ILoggerFactory.
Add Unit Tests (integration?) in case of instrumental lyric.

Owner Author

skuill commented Dec 16, 2023

https://www.musixmatch.com/lyrics/409/49881086
AZLyrics did not find any instrumental song
https://genius.com/Rush-yyz-lyrics
https://www.songlyrics.com/rush/yyz-lyrics/
https://lyrics.lyricfind.com/lyrics/rush-yyz

skuill added a commit that referenced this issue


          #17 Add ability to configure logging using WithLogger method in main …

83de1cc

…Client and Providers. Added Instrumental flag to the ResponseMessage.

skuill added a commit that referenced this issue


          #17 Fix Lint Comments

9fda657

skuill added a commit that referenced this issue


          #17 Refactoring. Set instrumentul result as Success.

8851b32

skuill added a commit that referenced this issue


          #17 Fixed instrumental song results for all providers except AZLyrics.

d8d9d44

skuill added a commit that referenced this issue


          #17 Fixed comments

db48c40

skuill added a commit that referenced this issue


          Merge pull request #18 from skuill/bugfix/17_instrumental_track

f24603c

#17 Error when searching for lyrics of an instrumental track

Owner Author

skuill commented Dec 19, 2023

Released in https://github.com/skuill/LyricsScraperNET/releases/tag/1.6.1

skuill closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment