Istio: add gateway-virtualservice link #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerlange
force-pushed
the
istio-gateway
branch
2 times, most recently
from
ba25b50
to
b719d81
Compare
|
run skydive-functional-tests-backend-orientdb |
hunchback
reviewed
Feb 24, 2019
hunchback
reviewed
Feb 24, 2019
hunchback
reviewed
Feb 24, 2019
hunchback
reviewed
Feb 24, 2019
tomerlange
force-pushed
the
istio-gateway
branch
4 times, most recently
from
210a220
to
efb1ae2
Compare
tomerlange
force-pushed
the
istio-gateway
branch
from
efb1ae2
to
1069b41
Compare
|
does not show the link connecting the gateway to virtualservice - I believe this is not consistent in all runs - kindly re-check |
I have checked this and this is not due to a bug in your code - rather this is a general issue effecting also other k8s resources (and possibly physical resources). so given that this issue will be solved outside the context of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds links between gateways and virtualservices.
The relevant tests are
TestBookInfoScenarioandTestIstioGatewayVirtualServiceScenario, which can be found attests/istio_test.go.