go: gimme to installs go v1.12.x #1966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunchback
force-pushed
the
go-v1.12.x
branch
7 times, most recently
from
62a0139 to
0e78a73
Compare
nplanel
requested changes
Sep 6, 2019
scripts/ci/install-go.sh
Outdated
| @@ -14,7 +14,7 @@ curl -sL -o ~/bin/gimme https://raw.githubusercontent.com/travis-ci/gimme/master | |||
| chmod +x ~/bin/gimme | |||
|
|
|||
| # before changing this be sure that it will not break the RHEL packaging | |||
| eval "$(gimme 1.10.3)" | |||
| eval "$(gimme 1.12.7)" | |||
| @@ -9,7 +9,7 @@ | |||
| - name: run gimme in bash profile | |||
| lineinfile: | |||
| path: /home/vagrant/.bash_profile | |||
| line: 'eval "$(gimme 1.10.8)"' | |||
| line: 'eval "$(gimme 1.12.7)"' | |||
| | grep -v '^tests') 2>&1 \ | ||
| | grep -v '^$(SKYDIVE_GITHUB)/tests' \ | ||
| | grep -v '^$(SKYDIVE_GITHUB)/contrib/collectd' \ | ||
| ) 2>&1 \ |
There was a problem hiding this comment.
'^$(SKYDIVE_GITHUB)/tests' as I don't remove the prefix anymore
| @test -z "$$($(GOVENDOR) fmt +local)" || \ | ||
| (echo "+ please format Go code with 'gofmt -s'" && /bin/false) | ||
| $(GOVENDOR) fmt +local || \ | ||
| (echo "+ please format Go code with '$(GOFMT)'" && /bin/false) |
There was a problem hiding this comment.
gofmt -s only we would like the output
There was a problem hiding this comment.
this is just the message to the user; and user should overwrite source (rather than output to stdout):
[vagrant@dev skydive]$ gofmt --help
usage: gofmt [flags] [path ...]
-cpuprofile string
write cpu profile to this file
-d display diffs instead of rewriting files
-e report all errors (not just the first 10 on different lines)
-l list files whose formatting differs from gofmt's
-r string
rewrite rule (e.g., 'a[b:len(a)] -> a[b:]')
-s simplify code
-w write result to (source) file instead of stdout
``
Makefile
Outdated
| @@ -32,9 +32,12 @@ $(call VENDOR_RUN,${PROTOC_GEN_GOFAST_GITHUB}) | |||
| $(call VENDOR_RUN,${PROTOC_GEN_GO_GITHUB}) protoc -Ivendor -I. --plugin=${BUILD_TOOLS}/protoc-gen-gogofaster --gogofaster_out $$GOPATH/src $1 | |||
| endef | |||
|
|
|||
| export GO111MODULE=off | |||
There was a problem hiding this comment.
why turning of on 1.11 only ?
should be always auto
There was a problem hiding this comment.
will remove leaving default. in 1.11 its' auto; it will change to on in future see: golang/go#31857
hunchback
force-pushed
the
go-v1.12.x
branch
from
0e78a73 to
5ad687e
Compare
|
replaced by: #1984 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgrade go to v1.12.x which supports go.mod dependencies