Neighbors step #2389
Merged
Neighbors step #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged after PR #2391, needs |
Do just one call to get all the edges for the given nodes, instead of one call for each node. This new call has been added as a new method to Graph and Backends. GetNodesEdges, return the list with all edges for a list of nodes. Batching is used to avoid hitting the max number of clauses set by ES (is set to the default value of 512).
adrianlzt
force-pushed
the
feature/step_neighbors
branch
from
f093a7d
to
88137ed
Compare
Open
adrianlzt
force-pushed
the
feature/step_neighbors
branch
from
88137ed
to
d66e0ea
Compare
Like Descendants, but using edges in any direction (Descendants only
uses edges from parent to child, Neighbors uses from parent to child and
from child to parent).
The different with the Both step, is Neighbors accumulate nodes seen.
Example (pseudo-syntax):
A -> B -> C
G.V(A).Out().Out() return: C.
But:
G.V(A).Neighbors(2) return: A,B,C
The parameters allowed are the same as in Descendants.
Example:
G.V('foo').Neighbors('RelationType',Within('ownership','foobar'),2)
To improve speed and reduce backend load when using persistent backends,
a new method, GetNodesFromIDs, is implemented in Graph and Backends.
This method only uses one call (or a few in we have hundreds of nodes,
see batching) to get all nodes from the backend.
Batching is used to avoid hitting the max number of clauses set by ES
(is set to the default value of 512).
adrianlzt
force-pushed
the
feature/step_neighbors
branch
from
d66e0ea
to
14bcafe
Compare
|
run skydive-k8s-tests |
adrianlzt
added a commit
to datadope-io/skydive
that referenced
this pull request
Sep 3, 2021
This two PRs add modifications to graffiti/graph/elasticsearch.go skydive-project#2391 skydive-project#2389 And bugfix to sync more than 10k docs break the API used. This commit adapt those two commits to use the new API (searchEdges and searchNodes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like Descendants, but using edges in any direction (Descendants only
uses edges from parent to child, Neighbors uses from parent to child and
from child to parent).
The different with the Both step, is Neighbors accumulate nodes seen.
Example (pseudo-syntax):
A -> B -> C
G.V(A).Out().Out() return: C.
But:
G.V(A).Neighbors(2) return: A,B,C
The parameters allowed are the same as in Descendants.
Example:
G.V('foo').Neighbors('RelationType',Within('ownership','foobar'),2)