Skip to content

Commit

Permalink
Update comments pointing to Lambda's docs (#4272)
Browse files Browse the repository at this point in the history
  • Loading branch information
cbrownstein-lambda authored Nov 6, 2024
1 parent 1dcd2f0 commit 654ed4a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions sky/provision/lambda_cloud/lambda_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def raise_lambda_error(response: requests.Response) -> None:
if status_code == 200:
return
if status_code == 429:
# https://docs.lambdalabs.com/cloud/rate-limiting/
# https://docs.lambdalabs.com/public-cloud/cloud-api/
raise LambdaCloudError('Your API requests are being rate limited.')
try:
resp_json = response.json()
Expand Down Expand Up @@ -145,7 +145,7 @@ def create_instances(
# Most API requests are rate limited at ~1 request every second but
# launch requests are rate limited at ~1 request every 10 seconds.
# So don't use launch requests to check availability.
# See https://docs.lambdalabs.com/cloud/rate-limiting/ for more.
# See https://docs.lambdalabs.com/public-cloud/cloud-api/ for more.
available_regions = (self.list_catalog()[instance_type]
['regions_with_capacity_available'])
available_regions = [reg['name'] for reg in available_regions]
Expand Down
2 changes: 1 addition & 1 deletion sky/skylet/providers/scp/node_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def _extract_metadata(self, vm: Dict[str, Any]) -> Dict[str, Any]:
metadata['tags'] = instance_info['tags']
# TODO(ewzeng): The internal ip is hard to get, so set it to the
# external ip as a hack. This should be changed in the future.
# https://docs.lambdalabs.com/cloud/learn-private-ip-address/
# https://docs.lambdalabs.com/public-cloud/on-demand/getting-started/#learn-your-instances-private-ip-address
metadata['internal_ip'] = vm['ip']
metadata['external_ip'] = vm['external_ip']
return metadata
Expand Down

0 comments on commit 654ed4a

Please sign in to comment.