Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serve] Display error message on old service before update mode is introduced. #4066

Open
cblmemo opened this issue Oct 10, 2024 · 0 comments
Labels
good first issue Good for newcomers serve features/bugs related to sky serve

Comments

@cblmemo
Copy link
Collaborator

cblmemo commented Oct 10, 2024

Seems like in the following code, we just silently ignored the mode argument.

@classmethod
def update_service(cls, service_name: str, version: int, mode: str) -> str:
code = [
# Backward compatibility for old serve version on the remote
# machine. The `mode` argument was added in #3249, and if the remote
# machine has an old SkyPilot version before that, we need to avoid
# passing the `mode` argument to the job_lib functions.
# TODO(zhwu): Remove this in 0.7.0 release.
f'mode_kwargs = {{"mode": {mode!r}}} '
'if getattr(constants, "SERVE_VERSION", 0) >= 1 else {}',
f'msg = serve_utils.update_service_encoded({service_name!r}, '
f'{version}, **mode_kwargs)',
'print(msg, end="", flush=True)',
]
return cls._build(code)

Expected behaviour: if a user specified a rolling update on an old service, we should raise an error says that rolling update is not supported on this service.

@cblmemo cblmemo added good first issue Good for newcomers serve features/bugs related to sky serve labels Oct 10, 2024
KrishivPiduri added a commit to KrishivPiduri/skypilot that referenced this issue Oct 12, 2024
KrishivPiduri added a commit to KrishivPiduri/skypilot that referenced this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers serve features/bugs related to sky serve
Projects
None yet
Development

No branches or pull requests

1 participant