Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: don't print refresh hint on status -r. #2077

Merged
merged 1 commit into from
Jun 13, 2023
Merged

UX: don't print refresh hint on status -r. #2077

merged 1 commit into from
Jun 13, 2023

Conversation

concretevitamin
Copy link
Member

@concretevitamin concretevitamin commented Jun 13, 2023 •
edited
Loading

Fixes #2060.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below): sky status -r
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Michaelvll
Michaelvll approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@Michaelvll Michaelvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this @concretevitamin!

@concretevitamin concretevitamin merged commit 144df8b into master Jun 13, 2023
@concretevitamin concretevitamin deleted the refresh-ux branch June 13, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX] sky status refresh hint message is confusing when --refresh is passed
2 participants
@concretevitamin @Michaelvll