[Core] Launching cluster autodowned or manually terminated #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoosukKwon
approved these changes
Jun 25, 2023
sky/backends/cloud_vm_ray_backend.py
Outdated
Comment on lines
3715
to
3717
| assert isinstance(previous_handle, | ||
| CloudVmRayResourceHandle), (previous_handle, | ||
| cluster_name) |
There was a problem hiding this comment.
Style nit: The code looks a bit ugly tbh.
Suggested change
| assert isinstance(previous_handle, | |
| CloudVmRayResourceHandle), (previous_handle, | |
| cluster_name) | |
| is_cloud_vm_handle = isinstance(previous_handle, | |
| CloudVmRayResourceHandle) | |
| assert is_cloud_vm_handle, (previous_handle, cluster_name) |
There was a problem hiding this comment.
Unfortunately, mypy is not clear enough to have this two-line assertion. I changed the output to be a string, so as to make it look a bit better. PTAL. : )
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
…nto fix-nonetype-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2129
We need to refactor the code in
executionand the_check_existing_cluster, as the optimization and the provision are actually quite coupled, as raised by @WoosukKwon before. This PR is a fix that will unblock the issue #2129, but not the coupled issue. In the long term, we need to rearchitect the code here.Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh