Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jobs] Remove assertion for one single controller resources. #4358

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Nov 14, 2024

A user reports when launch a managed jobs, following assertion error appears:

  File "sky/jobs/core.py", line 128, in launch
    assert len(controller_task.resources) == 1, controller_task
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This is due to the multi-controller resources we introduces in #4053. Fixed now

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

@cblmemo cblmemo added this pull request to the merge queue Nov 14, 2024
Merged via the queue into master with commit 6dd7051 Nov 14, 2024
20 checks passed
@cblmemo cblmemo deleted the fix-jobs-controller-resources branch November 14, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants