Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] NoCloudAccessError check is escaped from storage sync #4366

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

HysunHe
Copy link
Contributor

@HysunHe HysunHe commented Nov 15, 2024

Resolve the issue #4367

After fix, the message shown:

Launching a new service 'http-server'. Proceed? [Y/n]:
⚙︎ Translating workdir to SkyPilot Storage...
Workdir: 'examples/serve/http_server' -> storage: 'skypilot-workdir-hysunhe-f650b5f9'.
sky.exceptions.NotSupportedError: Unable to use workdir - no cloud with object store is enabled. Please enable at least one cloud with object store support (AWS, GCP, Azure, IBM, Cloudflare) by running sky check, or remove workdir from your task.
Hint: If you do not have any cloud access, you may still download data and code over the network using curl or other tools in the setup section of the task.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @HysunHe ! LGTM.

@cblmemo cblmemo added this pull request to the merge queue Nov 15, 2024
Merged via the queue into skypilot-org:master with commit fa798d7 Nov 15, 2024
20 checks passed
@HysunHe HysunHe deleted the patch-1 branch November 15, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants