BUG: Move handling of context arguments after handling of .depends keyword

skypy/pipeline/_pipeline.py

@@ -102,8 +102,6 @@ def __init__(self, configuration):
             self.dag.add_node(job, skip=False)
             if isinstance(settings, Item):
                 items[job] = settings
-                # infer additional item properties from context
-                settings.infer(context)
         for table, columns in self.table_config.items():
             table_complete = '.'.join((table, 'complete'))
             self.dag.add_node(table_complete)
@@ -115,8 +113,6 @@ def __init__(self, configuration):
                 self.dag.add_edge(job, table_complete)
                 if isinstance(settings, Item):
                     items[job] = settings
-                    # infer additional item properties from context
-                    settings.infer(context)
                 # DAG nodes for individual columns in multi-column assignment
                 names = [n.strip() for n in column.split(',')]
                 if len(names) > 1:
@@ -138,6 +134,8 @@ def __init__(self, configuration):
                 while c:
                     self.dag.add_edge(c, d)
                     c, d = c.rpartition('.')[0], c
+            # infer additional item properties from context
+            settings.infer(context)
 
     def execute(self, parameters={}):
         r'''Run a pipeline.

skypy/pipeline/tests/data/bug_464.yml

@@ -0,0 +1,7 @@
+tables:
+  bug_table_1:
+    a: !numpy.random.uniform [0, 1, 10]
+  bug_table_2:
+    .init: !astropy.table.vstack
+      tables: [ $bug_table_1 ]
+      .depends: [ bug_table_1.complete ]

skypy/pipeline/tests/test_skypy.py

@@ -100,9 +100,25 @@ def test_logging(capsys):
     assert(not err)
 
 
+def test_init_depends():
+
+    # Regression test for pull request #464
+    # Previously the .depends keyword was also being passed to functions as a
+    # keyword argument. This was because of an inconsistency of how the config
+    # file was parsed and how the .depends keyword was handled by the Pipeline
+    # class during execution. The .depends keyword is now handled exclusively
+    # by the Call class.
+
+    # Run skypy with default verbosity and check log is empty
+    filename = get_pkg_data_filename('data/bug_464.yml')
+    output_file = 'bug_464.fits'
+    assert skypy.main([filename, output_file]) == 0
+
+
 def teardown_module(module):
 
     # Remove fits file generated in test_skypy
+    os.remove('bug_464.fits')
     os.remove('empty.fits')
     os.remove('logging.fits')
     os.remove('test.fits')