Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: flake8 E275 fixes #572

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Conversation

itrharrison
Copy link
Contributor

Description

Merging will close #571 .

This simply addresses some test failures on flake8 E275 (missing whitespace after keyword).

@itrharrison itrharrison requested a review from a team as a code owner August 25, 2022 10:02
@itrharrison itrharrison linked an issue Aug 25, 2022 that may be closed by this pull request
@itrharrison itrharrison changed the title flake8 E275 fixes MAINT: flake8 E275 fixes Aug 25, 2022
@itrharrison itrharrison mentioned this pull request Aug 25, 2022
5 tasks
@ntessore
Copy link
Member

While this fixes the errors, flake8 is of course right: The keywords return, assert, and del are not function calls and should not be parenthesised.

Copy link
Member

@ntessore ntessore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itrharrison itrharrison merged commit 86e4ecf into main Aug 26, 2022
@rrjbca rrjbca deleted the 571-maint-fix-e275-test-failures branch September 8, 2024 11:08
rrjbca pushed a commit to rrjbca/skypy that referenced this pull request Sep 8, 2024
* flake8 E275 fixes

* removed parentheses
rrjbca pushed a commit that referenced this pull request Sep 8, 2024
* flake8 E275 fixes

* removed parentheses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: Fix E275 test failures
2 participants