tox indexserver is deprecated; use PIP_INDEX_URL and PIP_EXTRA_INDEX_URL in dev environments #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…URL in dev environments
itrharrison
approved these changes
Mar 31, 2023
rrjbca
added a commit
to rrjbca/skypy
that referenced
this pull request
Mar 31, 2023
…URL in dev environments (skypyproject#597)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tox indexserver configuration has been removed. This is causing the compatibility workflow to fail for dev environments which attempt to install numpy and scipy from the scipy-nightly-wheels server. This pull request modifies the tox dev environments to instead set the PIP_INDEX_URL and PIP_EXTRA_INDEX_URL environment variables to scipy-nightly-wheels and PyPI respectively.
I have tested this on a branch where I modified the compatibility workflow to be run on git pushes (rather than a cron schedule):
(Note that the passing tests installed numpy==1.25.0.dev0+941.gb35aac2c3 and scipy==1.11.0.dev0 develop versions from scipy-nightly-wheels while all other dependencies are releases installed from PyPI as intended).
Checklist