Avoid NullPointerException describing null value #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
commented
Apr 2, 2023
Comment on lines
+56
to
+58
| if (expectedValue == null || actualValue == null) { | ||
| result.fail(prefix, expectedValue, actualValue); | ||
| } | ||
| if (areNumbers(expectedValue, actualValue)) { | ||
| } else if (areNumbers(expectedValue, actualValue)) { |
There was a problem hiding this comment.
Removed extra "always true" non-null checks and do not attempt to fail for other reasons when already failing due to one value being null.
|
@carterpage , please take a look. |
|
Thanks for the ping. Looks good. I'll try to get this merged and released this weekend. |
|
@carterpage status on this PR? fixes an issue I'm having (#171) |
Signed-off-by: Michael Edgar <michael@xlate.io>
|
I hit this too and was preparing to submit a similar PR. |
|
I have been getting new releases going again, and will try to get this included in the new v2 in the next couple of weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171