Automate the correction of website #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibuibu
requested review from
a team,
riosu and
d-matsui
and removed request for
a team
riosu
requested changes
Jan 15, 2021
| @@ -34,3 +54,62 @@ async function hasChangeLog(version) { | |||
| rl.once('close', () => resolve(false)); | |||
| }); | |||
| } | |||
|
|
|||
| async function checkExampleSdkVersion(version, file) { | |||
There was a problem hiding this comment.
To use this function in isCorrectReadmeVersion, We can change this function as follows:
function isSdkVersionURLCorrect(version, filepath) {
const data = fs.readFileSync(filepath, "utf8");
const matches = data.matchAll(/cdn\.webrtc\.ecl\.ntt\.com\/skyway-([0-9]+\.[0-9]+\.[0-9]+)(\.min)?\.js/g);
for (const match of matches) {
if (match[1] !== version) {
return false;
}
}
return true;
}
isSdkVersionURLCorrect("4.2.0", "README.md");| echo "Website is up to date. Skip updating website." | ||
| exit 0 | ||
| fi | ||
| sed -i -e "s/[0-9]\.[0-9]\.[0-9]/${version}/g" skyway-official-web-site/docs/documents/javascript-sdk.md |
There was a problem hiding this comment.
I'd like to narrow down the scope of regular expressions a bit.
| exit 0 | ||
| fi | ||
| sed -i -e "s/[0-9]\.[0-9]\.[0-9]/${version}/g" skyway-official-web-site/docs/documents/javascript-sdk.md | ||
| sed -i -e "s/[0-9]\.[0-9]\.[0-9]/${version}/g" skyway-official-web-site/docs/en/documents/javascript-sdk.md |
There was a problem hiding this comment.
Currently, when there are two digits, as in 1.4.41, they are not replaced.
riosu
approved these changes
Jan 15, 2021
d-matsui
approved these changes
Jan 17, 2021
This was referenced Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the type of change your PR introduces
Summary
Supplement
The SSH Key is set in the project of circleCI.
Check point