Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tabnabbing vulnerability in Snow theme #2439

Merged
merged 2 commits into from
Dec 28, 2018
Merged

Fix tabnabbing vulnerability in Snow theme #2439

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b750c9c
Fix tabnabbing vulnerability in Snow theme
jonathanlloyd Dec 21, 2018
99a85c1
Minimal fix for tabnabbing
jonathanlloyd Dec 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion themes/snow.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class SnowTooltip extends BaseTooltip {
}
}
SnowTooltip.TEMPLATE = [
'<a class="ql-preview" target="_blank" href="about:blank"></a>',
'<a class="ql-preview" rel="noopener noreferrer nofollow" target="_blank" href="about:blank"></a>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nofollow does not seem relevant to tabnabbing?

Copy link
Contributor Author

@jonathanlloyd jonathanlloyd Dec 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, noopener is sufficient to mitigate tabnabbing. I've left in noreferrer for privacy reasons but can remove that too if you think it's too much.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine these two are what React's linter suggests as well

'<input type="text" data-formula="e=mc^2" data-link="https://quilljs.com" data-video="Embed URL">',
'<a class="ql-action"></a>',
'<a class="ql-remove"></a>',
Expand Down