MNT/REF: script cleanup and clarification #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated files now match those in the repository.
JJL772
approved these changes
Jan 29, 2022
|
Sorry for stepping on toes here, @JJL772 - I hope one day soon you'll be at SLAC to take this all over again and complain to us at length about how we screwed things up 😉 In the meantime, here we go... Will try the new module on Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I/O Intras we switched over to that in Massive changes. #14And other minor things:
Makefilefor scripts that downloads and generates headers/databases with one commandisortto sort and clean up Python importsI think this paves the way for easily supporting the EL2794. If all of this looks good, I'll open another PR adding that module next.