-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add find_terminal tool and EL2794 support #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please tell me terminals.h is a generated file though. Because otherwise, NUM_TERMINALS gives me the heebie-jeebies. I'd much rather see it defined as (sizeof(g_pTerminalInfos)/sizeof(g_pTerminalInfos[0])) and no size on the g_pTerminalInfos array.
It is, @mcb64 : https://github.com/slaclab/epics-ek9000/blob/6dedab47cad23ce7d802503ba72868667bbea3c4/ek9000App/src/scripts/Makefile#L11-L12 Though I agree letting the compiler take care of it would be preferable |
I suggest adding an template<class T, size_t N>
size_t ArraySize(T(&arr)[N]) {
return N;
} Should work in old C++ standards too |
I'll open an issue for the array size thing and go ahead with this one. 👍 |
find_terminal.py
This is part of the effort to better understand the library and get the EL2794 in (the latter being a comparatively simple task...)
Starting with a tool to scrape the xml files better in order to add a given terminal:
Considers the different possible syncmanager mappings and sees if there's a match in
terminals.json
. Will be using this (or a fixed up version of it) to gather information for new terminals.EL2794 support
ioc-peppex-test
)Think I'm missing anything here, @JJL772 or @mcb64 ?