Replace NUM_TERMINALS with ArraySize #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't rely on generated size macro
JJL772
changed the title
mcb64
approved these changes
Feb 3, 2022
|
Let me try building this on the accelerator's ancient g++ first just to verify... |
JJL772
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUM_TERMINALS was generated and bad.
Closes #21
Should also note that
g_pTerminalInfosis a bit of a misnomer since it's not really a pointer.Let's also wait for the other PRs to be merged before merging this guy. I'll rebase this and regenerate terminals.h once the others are merge.d