Fix existing linter issues

.golangci.yml

@@ -11,5 +11,4 @@ linters:
     - structcheck
     - unconvert
 issues:
-  # TODO(kanata2): fix existing issues
   new: true

block_header_test.go

@@ -12,7 +12,7 @@ func TestNewHeaderBlock(t *testing.T) {
 
 	headerBlock := NewHeaderBlock(textInfo, HeaderBlockOptionBlockID("test_block"))
 	assert.Equal(t, string(headerBlock.Type), "header")
-	assert.Equal(t, string(headerBlock.BlockID), "test_block")
+	assert.Equal(t, headerBlock.BlockID, "test_block")
 	assert.Equal(t, headerBlock.Text.Type, "plain_text")
 	assert.Contains(t, headerBlock.Text.Text, "quite the header")
 }

block_section_test.go

@@ -12,7 +12,7 @@ func TestNewSectionBlock(t *testing.T) {
 
 	sectionBlock := NewSectionBlock(textInfo, nil, nil, SectionBlockOptionBlockID("test_block"))
 	assert.Equal(t, string(sectionBlock.Type), "section")
-	assert.Equal(t, string(sectionBlock.BlockID), "test_block")
+	assert.Equal(t, sectionBlock.BlockID, "test_block")
 	assert.Equal(t, len(sectionBlock.Fields), 0)
 	assert.Nil(t, sectionBlock.Accessory)
 	assert.Equal(t, sectionBlock.Text.Type, "mrkdwn")

reminders_test.go

@@ -8,7 +8,6 @@ import (
 
 type remindersHandler struct {
 	gotParams map[string]string
-	response  string
 }
 
 func newRemindersHandler() *remindersHandler {

slacktest/handlers.go

@@ -62,7 +62,7 @@ func (sts *Server) conversationsInfoHandler(w http.ResponseWriter, r *http.Reque
 	ch := values.Get("channel")
 
 	response := GroupConversationResponse{
-		Ok:      true,
+		Ok: true,
 		Channel: slack.GroupConversation{
 			Conversation: slack.Conversation{
 				ID: ch,

websocket_managed_conn_test.go

@@ -101,7 +101,7 @@ func TestRTMGoodbye(t *testing.T) {
 
 	select {
 	case <-done:
-		// magic numbers from emperical testing.
+		// magic numbers from empirical testing.
 		assert.Equal(t, connected <= 7, true)
 		assert.Equal(t, disconnected <= 12, true)
 	case <-time.After(5 * time.Second):
@@ -158,7 +158,7 @@ func TestRTMDeadConnection(t *testing.T) {
 
 	select {
 	case <-done:
-		// magic numbers from emperical testing.
+		// magic numbers from empirical testing.
 		assert.Equal(t, connected <= 7, true)
 		assert.Equal(t, disconnected <= 7, true)
 	case <-time.After(5 * time.Second):