Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No running server for button tests - fixed #773

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

musinit
Copy link

@musinit musinit commented Aug 9, 2020

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

@kanata2 kanata2 added the example about example codes label Aug 17, 2020
@kanata2
Copy link
Member

kanata2 commented Aug 17, 2020

Thanks!

@kanata2 kanata2 merged commit d206f6d into slack-go:master Aug 17, 2020
@kanata2 kanata2 added this to the v0.7.0 milestone Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example about example codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants