Update API methods from slack-api-ref #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeurer
changed the title
Closed
Generated by 🚫 danger |
|
The error from "danger" should be fixed, forgot a hyphen. I amended the commit and force-pushed, will it run again? |
dblock
reviewed
Jan 22, 2018
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| * [#187](https://github.com/slack-ruby/slack-ruby-client/pull/187): Concatenate error message when multiple errors present - [@chrislopresto](https://github.com/chrislopresto). | |||
| * [#188](https://github.com/slack-ruby/slack-ruby-client/pull/188): Fixed `NoMethodError` when Slack is unavailable - [@sonicdoe](https://github.com/sonicdoe). | |||
| * [#196](https://github.com/slack-ruby/slack-ruby-client/pull/196): Update API methods from slack-api-ref - [@manuelmeurer](https://github.com/manuelmeurer). | |||
There was a problem hiding this comment.
For consistency we list the actual API changes. This should say "added lookupByEmail`, etc., see below for examples.
There was a problem hiding this comment.
Ok, will change that and also squash both commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #193