Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Block Kit #253

Merged
merged 4 commits into from
Feb 24, 2019
Merged

Add support for Block Kit #253

merged 4 commits into from
Feb 24, 2019

Conversation

JrmKrb
Copy link
Contributor

@JrmKrb JrmKrb commented Feb 19, 2019

  • Updates Slack API
  • Patches Blocks to be JSON-string encoded
  • Specs

I think it's ready to merge and it would be nice to have it released soon.

It closes #251 and takes the place of #252 that was not patching properly the Web API to mimic attachments behavior.

@JrmKrb JrmKrb changed the title Add support for Block kit Add support for Block Kit Feb 19, 2019
@abinoda
Copy link

abinoda commented Feb 19, 2019

Dear maintainers, please publish a release once this is merged!

@jmanian jmanian requested a review from dblock February 20, 2019 18:35
@dblock dblock merged commit c6f0719 into slack-ruby:master Feb 24, 2019
@dblock
Copy link
Collaborator

dblock commented Feb 24, 2019

Looks great, merged. Thank you.

@dblock
Copy link
Collaborator

dblock commented Feb 24, 2019

I plan to do a release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack::Web::Client needs to be updated to support the Slack's new blocks parameter
4 participants