feat: log info and errors using the @slack/logger package #84
+106
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
reviewed
Aug 23, 2024
| @@ -61,10 +62,11 @@ registerListeners(app); | |||
|
|
|||
| /** Start Bolt App */ | |||
| (async () => { | |||
| const logger = new ConsoleLogger(); | |||
There was a problem hiding this comment.
This is at least better than now, but we may want to expose app.logger and use it here. With that, developers can control the logging level consistently
There was a problem hiding this comment.
🤩 I think that'd be most ideal! I agree that setting these levels in separate place isn't the best experience at the moment...
I'm also realizing this logger should be set to debug to match the app anyways!
perhaps a temporary change? #84 (comment)
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
This PR uses
@slack/logger- both instantiated and in listeners - as an interface to theconsoleto avoid linting errors and respond tologger.setLevelchangesReviewers
Setup an app and inspect the logs 🔍
$ npm run start ... [DEBUG] web-api:WebClient:1 apiCall('apps.connections.open') end [DEBUG] socket-mode:SocketModeClient:0 Transitioning to state: connecting:authenticated - ⚡️ Bolt app is running! + [INFO] ⚡️ Bolt app is running! [DEBUG] web-api:WebClient:0 http response receivedNotes
If this seems like a solid change, I can copy it over to other Bolt JS samples!
Requirements