Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1040 Remove invalid warning logs for logger initialization #1078

Merged
merged 1 commit into from
Aug 24, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/App.ts
Original file line number Diff line number Diff line change
Expand Up @@ -251,12 +251,6 @@ export default class App {
// only logLevel is passed
this.clientOptions.logLevel = logLevel;
} else {
if (logLevel !== undefined) {
// If the constructor has both, logLevel is ignored
this.logger.warn(
"As `logger` is passed as well, `logLevel` argument won't be used. Set the log level to the `logger` instance instead.",
);
}
// Since v3.4, WebClient starts sharing loggger with App
this.clientOptions.logger = this.logger;
}
Expand Down