-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code to fix TS v.4.4 compiler errors #1091
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1091 +/- ##
==========================================
+ Coverage 70.90% 71.03% +0.13%
==========================================
Files 13 13
Lines 1220 1229 +9
Branches 365 365
==========================================
+ Hits 865 873 +8
- Misses 284 287 +3
+ Partials 71 69 -2
Continue to review full report at Codecov.
|
Casting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
Perhaps any additional coverage improvements could be worked on in a separate PR in order to move ahead with merging this? This way the other PRs waiting on this project can move forward? The ESLint config update PR, for example, is itself a blocker to merging two other open PRs.
EDIT: Woops, didn't notice that the coverage diff GitHub Action check is actually blocking merging this PR - I'll see if I can add some tests to help that.
Oh, but I think that we don't need to be too strict about it. Particularly, for this pull request, we can consider merging it as early as possible not to block other pull requests. |
I've opened #1094 adding an additional test for |
…for invoking the installRedirectHandler
Oh geez, I 'merged' my test expansion not realizing that this PR is based off of @srajiang's fork 😆 😢 🙈 Anyways, the |
Summary
Fix #1089 by updating code which causes Typescript v4.4.1 compiler errors.
Requirements (place an
x
in each[ ]
)