Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1014 - Adds JP translation for token rotation changes. #1175

Merged
merged 3 commits into from
Oct 22, 2021
Merged

Fixes #1014 - Adds JP translation for token rotation changes. #1175

merged 3 commits into from
Oct 22, 2021

Conversation

wongjas
Copy link
Member

@wongjas wongjas commented Oct 22, 2021

Summary

Fixes #1014. Adds JP translation for token rotation changes.

Requirements (place an x in each [ ])

@wongjas wongjas requested a review from seratch October 22, 2021 01:06
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1175 (5f44f9b) into main (02ca6e1) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1175      +/-   ##
==========================================
+ Coverage   71.71%   71.83%   +0.12%     
==========================================
  Files          15       15              
  Lines        1354     1360       +6     
  Branches      402      405       +3     
==========================================
+ Hits          971      977       +6     
  Misses        312      312              
  Partials       71       71              
Impacted Files Coverage Δ
src/App.ts 83.90% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ca6e1...5f44f9b. Read the comment docs.

@seratch seratch added this to the 3.8.0 milestone Oct 22, 2021
@seratch seratch added the docs M-T: Documentation work only label Oct 22, 2021
@wongjas wongjas marked this pull request as ready for review October 22, 2021 03:30
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seratch seratch merged commit 2c12dba into slackapi:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Japanese docs to apply token rotation (#1009) changes
2 participants