Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ts to PinnedMessageItem interface #2164

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

maxretries
Copy link
Contributor

Summary

fixes #2163

message ts is missing in PinnedMessageItem interface, however this is sent in the event from the server. This PR adds ts to the interface.

Requirements (place an x in each [ ])

Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): maxretries <m***@p***.me>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (0afa1e6) to head (4998d14).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2164   +/-   ##
=======================================
  Coverage   82.07%   82.07%           
=======================================
  Files          18       18           
  Lines        1545     1545           
  Branches      443      443           
=======================================
  Hits         1268     1268           
  Misses        179      179           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@filmaj filmaj added this to the 3.20.0 milestone Jul 12, 2024
@filmaj filmaj added enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific labels Jul 12, 2024
@filmaj filmaj merged commit c00bad7 into slackapi:main Jul 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed enhancement M-T: A feature request for new functionality semver:minor TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PinnedMessageItem interface missing ts
2 participants