Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add xapp section #2339

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

kuredev
Copy link
Contributor

@kuredev kuredev commented Nov 19, 2024

Summary

I added an explanation about saving a certain environment variable to the Japanese documentation since it was mentioned in the English documentation but not in the Japanese one.

en

image

ja

image

Requirements (place an x in each [ ])

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (7020a2e) to head (2662aa3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2339   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          36       36           
  Lines        7472     7472           
  Branches      651      651           
=======================================
  Hits         6911     6911           
  Misses        553      553           
  Partials        8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kuredev kuredev force-pushed the add_xapp_section-getting-started-ja branch 2 times, most recently from a48bbbb to 5017edc Compare November 19, 2024 05:28
@kuredev kuredev force-pushed the add_xapp_section-getting-started-ja branch from 5017edc to c47726f Compare November 19, 2024 05:29
@kuredev kuredev marked this pull request as ready for review November 19, 2024 06:04
@seratch seratch added the docs M-T: Documentation work only label Nov 19, 2024
@seratch seratch added this to the 4.x milestone Nov 19, 2024
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the time to improve the docuement! May I ask you to work on the HTTP tab too?

</TabItem>
<TabItem value="http" label="HTTP">

作業中です!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't mind, can I ask you to work on this too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I misunderstood the meaning of "Carry on!"

It seems that saving the xapp token is unnecessary in HTTP mode, so I think it's fine to proceed without setting it.

Therefore, I fixed it to mean "please proceed as is." How does this look? 13a72bf

@kuredev kuredev force-pushed the add_xapp_section-getting-started-ja branch from c82ce80 to 13a72bf Compare November 19, 2024 08:17
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Thank you so much for taking the time!

@seratch seratch merged commit 01558b5 into slackapi:main Nov 19, 2024
20 checks passed
@kuredev kuredev deleted the add_xapp_section-getting-started-ja branch November 19, 2024 08:25
@filmaj filmaj modified the milestones: 4.x, 4.1.1 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:signed docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants