Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for publishing to home tab #626

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

shaydewael
Copy link
Contributor

Summary

This should have been added a while ago, but better late than never.

This section shows how to use views.publish and the app_home_opened event to update a user's home tab.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Sep 15, 2020
@shaydewael
Copy link
Contributor Author

image

@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #626 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   83.27%   83.27%           
=======================================
  Files           7        7           
  Lines         598      598           
  Branches      193      193           
=======================================
  Hits          498      498           
  Misses         67       67           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e51d4...13a3da2. Read the comment docs.

}
});

console.log(result);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove the console.log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've typically logged result for other responses, but fine with either.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine leaving it. PR looks good to me!

@shaydewael shaydewael added docs M-T: Documentation work only and removed untriaged labels Sep 15, 2020
@shaydewael shaydewael merged commit ad1493d into slackapi:main Sep 17, 2020
@shaydewael shaydewael deleted the add-app-home-documentation branch September 17, 2020 16:01
seratch added a commit to seratch/bolt-js that referenced this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants