-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update message types #782
Update message types #782
Conversation
2be890f
to
67c8091
Compare
For context, I found the file type here: https://api.slack.com/types/file |
src/types/events/message-events.ts
Outdated
@@ -13,16 +13,23 @@ export type MessageEvent = | |||
export interface GenericMessageEvent { | |||
type: 'message'; | |||
subtype: undefined; | |||
event_ts: string; | |||
team: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this field does not always exist, we may want to make it optional.
text: string; | ||
blocks?: (KnownBlock | Block)[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, attachments
is missing.
Can you update the spec file to be compatible with the new type definition?
Apart from this build failure, this PR looks great to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can merge this once the build failure is fixed.
This branch still have a lint error. You need to apply code formatter to the modified spec files. Can you run |
b205412
to
b08dd3d
Compare
Summary
Addresses #774 and updates other fields that were missing
Requirements (place an
x
in each[ ]
)