Fix #897 Add built-in fields to Context object type #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #902 +/- ##
=======================================
Coverage 66.19% 66.19%
=======================================
Files 13 13
Lines 1204 1204
Branches 355 355
=======================================
Hits 797 797
Misses 338 338
Partials 69 69 Continue to review full report at Codecov.
|
seratch
commented
Apr 29, 2021
|
@stevengill Thanks! I'm glad that we can move this forward 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the built-in fields in
Contextinterface. The change does not bring any breaking changes. It just bring minor improvements for TypeScript users and better auto-completion in VS Code. Feedback / suggestions about the comments are welcome!As I would like to know others' thoughts on this, this is still in draft stage. If other maintainers are fine with this, I will add this to v3.4 milestone.
This PR fixes #897 if it's merged.
Requirements (place an
xin each[ ])