Fix #911 TypeScript error when using builtin onlyViewActions middleware #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
added
bug
seratch
commented
May 11, 2021
| @@ -4,6 +4,7 @@ import { ListenOptions } from 'net'; | |||
| import { parse as qsParse } from 'querystring'; | |||
| import { Logger, ConsoleLogger, LogLevel } from '@slack/logger'; | |||
| import { InstallProvider, CallbackOptions, InstallProviderOptions, InstallURLOptions } from '@slack/oauth'; | |||
| import { URL } from 'url'; | |||
There was a problem hiding this comment.
This is not related to this issue but I found that tsd with the latest type definition fails with the following error:
> @slack/bolt@3.3.0 test:types /Users/ksera/github/bolt-js
> tsd
src/receivers/HTTPReceiver.ts:237:35
✖ 237:35 Cannot find name URL.
1 error
npm ERR! code ELIFECYCLE
10 tasks
Codecov Report
@@ Coverage Diff @@
## main #912 +/- ##
==========================================
+ Coverage 66.19% 66.22% +0.02%
==========================================
Files 13 13
Lines 1204 1205 +1
Branches 355 355
==========================================
+ Hits 797 798 +1
Misses 338 338
Partials 69 69
Continue to review full report at Codecov.
|
mwbrooks
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request resolves #911. Refer to the issue for details.
Requirements (place an
xin each[ ])